update so that project can run on latest crictl version#183
Open
update so that project can run on latest crictl version#183
Conversation
Signed-off-by: Ermin Hrkalovic <ermin.hrkalovic@outlook.com>
Contributor
Author
|
We only run the |
Signed-off-by: Ermin Hrkalovic <ermin.hrkalovic@outlook.com>
No9
previously approved these changes
Mar 10, 2026
Contributor
Author
|
@No9 thanks for the approval! I see no way to merge this from my side, is this something you can do? |
Dockerfile
Outdated
| FROM registry.access.redhat.com/ubi7/ubi as rhel7builder | ||
| FROM registry.access.redhat.com/ubi7/ubi AS rhel7builder | ||
|
|
||
| ARG CRICTL_VERSION=1.33.0 |
There was a problem hiding this comment.
The ARG will need to be moved to rhel8builder to be visible since that is the layer in which it is used.
Signed-off-by: Ermin Hrkalovic <ermin.hrkalovic@guerrilla-games.com>
swermin
force-pushed
the
feature/upgrade
branch
from
d6b7b4c to
35a3446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of
core-dump-handlerdoesn't work with Kubernetes 1.33 and beyond.This PR updates the
muslversion, which is multiarch, to the latest version of crictl and also makes the crictl version an build-arg in case someone needs to update it.Running the docker file seems to fail on compiling, so this PR also includes fixes to latest rust compatibility.